Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41317: Remove reader on cancellation in asyncio.loop.sock_accept() #21595

Merged
merged 2 commits into from
Jul 23, 2020
Merged

bpo-41317: Remove reader on cancellation in asyncio.loop.sock_accept() #21595

merged 2 commits into from
Jul 23, 2020

Conversation

agronholm
Copy link
Contributor

@agronholm agronholm commented Jul 22, 2020 •
edited by bedevere-bot
Loading

@1st1
Copy link
Member

1st1 commented Jul 22, 2020

Looks good to me. @fantix could you please also look at this PR?

fantix
fantix suggested changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me!

Lib/asyncio/selector_events.py Outdated Show resolved Hide resolved
fantix
fantix approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@1st1 1st1 added the needs backport to 3.9 only security fixes label Jul 23, 2020
@1st1 1st1 merged commit 0dd98c2 into python:master Jul 23, 2020
@bedevere-bot
Copy link

@1st1: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @agronholm for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@1st1
Copy link
Member

1st1 commented Jul 23, 2020

@fantix Thanks for the review!

@bedevere-bot
Copy link

GH-21603 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 23, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2020
@agronholm @miss-islington
bpo-41317: Remove reader on cancellation in asyncio.loop.sock_accept() (
88c8dd9 
pythonGH-21595)

(cherry picked from commit 0dd98c2)

Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
@agronholm agronholm deleted the fix-issue-41317 branch July 23, 2020 19:46
miss-islington added a commit that referenced this pull request Jul 23, 2020
@miss-islington @agronholm
bpo-41317: Remove reader on cancellation in asyncio.loop.sock_accept() (
4ff8e5b 
GH-21595)

(cherry picked from commit 0dd98c2)

Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@agronholm @shihai1991
bpo-41317: Remove reader on cancellation in asyncio.loop.sock_accept() (
e89752d 
python#21595)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@agronholm @shihai1991
bpo-41317: Remove reader on cancellation in asyncio.loop.sock_accept() (
8084969 
python#21595)
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@agronholm
bpo-41317: Remove reader on cancellation in asyncio.loop.sock_accept() (
689824c 
python#21595)
@agronholm agronholm mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantix fantix fantix approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@agronholm @1st1 @bedevere-bot @miss-islington @fantix @the-knights-who-say-ni