Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-4630: Fix errors in Lib/idlelib/NEWS.txt #21594

Merged
merged 1 commit into from
Jul 23, 2020
Merged

bpo-4630: Fix errors in Lib/idlelib/NEWS.txt #21594

merged 1 commit into from
Jul 23, 2020

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Jul 22, 2020 •
edited by bedevere-bot
Loading

terryjreedy
terryjreedy approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect the backport to 3.9 will work. I believe the NEWS.txt change would backport to 3.8 would work, but the Misc/NEWS.d to not do so. If is does not, you can submit a separate [3.8] ... PR.

Lib/idlelib/NEWS.txt
@@ -63,9 +63,9 @@ bpo-38636: Fix IDLE Format menu tab toggle and file indent width. These
functions (default shortcuts Alt-T and Alt-U) were mistakenly disabled
in 3.7.5 and 3.8.0.

bpo-4360: Add an option to toggle IDLE's cursor blink for shell,
bpo-4630: Add an option to toggle IDLE's cursor blink for shell,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a typo

Lib/idlelib/NEWS.txt
editor, and output windows. See Settings, General, Window Preferences,
Cursor Blink. Patch by Zachary Spytz.
Cursor Blink. Patch by Zackery Spytz.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this is an error, for which I apologize.

@terryjreedy terryjreedy added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes and removed skip issue labels Jul 23, 2020
@terryjreedy
Copy link
Member

terryjreedy commented Jul 23, 2020 •
edited
Loading

@Mariatta , @vstinner After 7 hours, Travis has not reported, and there is no Details link to halt or restart. The odd thing is that when Travis starts, there is a Details link, but it gets taken away later.
(Will close and reopen to restart all)

@terryjreedy terryjreedy reopened this Jul 23, 2020
@terryjreedy terryjreedy merged commit 592527f into python:master Jul 23, 2020
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 23, 2020
@ZackerySpytz @miss-islington
bpo-4630: Fix errors in Lib/idlelib/NEWS.txt (pythonGH-21594)
fcd6b1e 
Also one in news log.
(cherry picked from commit 592527f)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

GH-21598 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 23, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Jul 23, 2020 •
edited by terryjreedy
Loading

Sorry, @ZackerySpytz and @terryjreedy, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 592527f3ee59616eca2bd1da771f7c14cee808d5 3.8

I will give this a try.

@bedevere-bot
Copy link

bedevere-bot commented Jul 23, 2020 •
edited by terryjreedy
Loading

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.x has failed when building commit 592527f.

https://buildbot.python.org/all/#builders/129/builds/1473

Summary of the results of the build (if available):

1 test altered the execution environment:
test_asyncio

EDIT: this is the failure -- unrelated!!

miss-islington added a commit that referenced this pull request Jul 23, 2020
@miss-islington @ZackerySpytz
bpo-4630: Fix errors in Lib/idlelib/NEWS.txt (GH-21594)
4cf7afc 
Also one in news log.
(cherry picked from commit 592527f)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Jul 23, 2020
@terryjreedy
[3.8] bpo-4630: Fix errors in Lib/idlelib/NEWS.txt (pythonGH-21594)
673707d 
Also one in news log.

(cherry picked from commit 592527f)
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Jul 23, 2020
@terryjreedy @ZackerySpytz
[3.8] bpo-4630: Fix errors in Lib/idlelib/NEWS.txt (pythonGH-21594)
162985c 
Also one in news log..
(cherry picked from commit 592527f)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

GH-21599 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Jul 23, 2020
terryjreedy added a commit that referenced this pull request Jul 23, 2020
@terryjreedy
[3.8] bpo-4630: Fix errors in Lib/idlelib/NEWS.txt (GH-21594)
29df301 
Also one in news log.

(cherry picked from commit 592527f)
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@vstinner
Copy link
Member

vstinner commented Aug 3, 2020

@Mariatta , @vstinner After 7 hours, Travis has not reported, and there is no Details link to halt or restart

Yeah, it happens: see python/core-workflow#371

@vstinner vstinner mentioned this pull request Aug 3, 2020
Closed
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@ZackerySpytz @shihai1991
bpo-4630: Fix errors in Lib/idlelib/NEWS.txt (pythonGH-21594)
b5ffc5c 
Also one in news log.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@ZackerySpytz @shihai1991
bpo-4630: Fix errors in Lib/idlelib/NEWS.txt (pythonGH-21594)
3c3e118 
Also one in news log.
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@ZackerySpytz
bpo-4630: Fix errors in Lib/idlelib/NEWS.txt (pythonGH-21594)
74d46f4 
Also one in news log.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

@terryjreedy terryjreedy

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZackerySpytz @terryjreedy @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni @nanjekyejoannah