Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Builtins functions: faster jump table #21376

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Jul 7, 2020

Having hard time fininding entries in the builtin functions jump table, told myself many times I should try to enhance it, tried myself at it today, here's what I got:

Screenshot_2020-07-07 Built-in Functions — Python 3 10 0a0 documentation

What do you think?

@JulienPalard
Copy link
Member Author

Hi @ambv, would you like to see this backported to 3.8 and 3.9?

@merwok
Copy link
Member

merwok commented Jul 10, 2020

(Watching here to get a confirmation if doc changes count as bugfixes!)

arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@verhovsky
Copy link
Contributor

verhovsky commented Jan 15, 2021

I think this is a good change, I've had trouble looking for names too, but this makes the page scroll left to right when viewed on mobile (or maybe it was some other change?). The 3.9 docs don't have this issue, you can only scroll them down. I'm not sure if this is the reason, but the table should also still take 100% of the available width on desktop, this version has some whitespace around it. See 3.9 vs 3.10:

Screenshot 2021-01-15 at 12 10 53 Screenshot 2021-01-15 at 12 10 36

@JulienPalard
Copy link
Member Author

JulienPalard commented Jan 20, 2021

Hi @verhovsky, thanks for reporting! Can you please open an issue about this on https://github.com/python/python-docs-theme/issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants