bpo-40521: Empty frozenset is no longer a singleton #21085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged the PR since I'm working on other changes which are in conflict with this PR, like PR #21086. |
fasih
pushed a commit
to fasih/cpython
that referenced
this pull request
Jun 29, 2020
* Revert "bpo-40521: Make the empty frozenset per interpreter (pythonGH-21068)" This reverts commit 261cfed. * bpo-40521: Empty frozensets are no longer singletons * Complete the removal of the frozenset singleton
arun-mani-j
pushed a commit
to arun-mani-j/cpython
that referenced
this pull request
Jul 21, 2020
* Revert "bpo-40521: Make the empty frozenset per interpreter (pythonGH-21068)" This reverts commit 261cfed. * bpo-40521: Empty frozensets are no longer singletons * Complete the removal of the frozenset singleton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the empty frozenset a singleton wasn't worth it. Unlike empty strings and empty tuples, these are not common and don't warrant a special case. Taking it out makes the code simpler.
https://bugs.python.org/issue40521