bpo-40791: Use CRYPTO_memcmp() for compare_digest #20456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
:func:`hashlib.compare_digest` uses OpenSSL's ``CRYPTO_memcmp()`` function when OpenSSL is available. Note: The ``_operator`` module is a builtin module. I don't want to add libcrypto dependency to libpython. Therefore I duplicated the wrapper function and added a copy to ``_hashopenssl.c``. Signed-off-by: Christian Heimes <christian@python.org>
gpshead
reviewed
May 27, 2020
gpshead
approved these changes
May 27, 2020
gpshead
added
type-feature
|
@gpshead 3.10-only or do you want to handle this as a security fix with backport to 3.7 to 3.9? |
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
@tiran: Please replace |
|
Sorry, @tiran, I could not cleanly backport this to |
tiran
added a commit
to tiran/cpython
that referenced
this pull request
May 27, 2020
hashlib.compare_digest uses OpenSSL's CRYPTO_memcmp() function when OpenSSL is available. Note: The _operator module is a builtin module. I don't want to add libcrypto dependency to libpython. Therefore I duplicated the wrapper function and added a copy to _hashopenssl.c.. (cherry picked from commit db5aed9) Co-authored-by: Christian Heimes <christian@python.org>
|
GH-20461 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
that referenced
this pull request
May 28, 2020
…H-20461) hashlib.compare_digest uses OpenSSL's CRYPTO_memcmp() function when OpenSSL is available. Note: The _operator module is a builtin module. I don't want to add libcrypto dependency to libpython. Therefore I duplicated the wrapper function and added a copy to _hashopenssl.c.. (cherry picked from commit db5aed9) Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:func:
hashlib.compare_digestuses OpenSSL'sCRYPTO_memcmp()functionwhen OpenSSL is available.
Note: The
_operatormodule is a builtin module. I don't want to addlibcrypto dependency to libpython. Therefore I duplicated the wrapper
function and added a copy to
_hashopenssl.c.Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue40791