Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing problems reported by mypy in pegen #20297

Merged
merged 1 commit into from
May 21, 2020
Merged

Fix typing problems reported by mypy in pegen #20297

merged 1 commit into from
May 21, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented May 21, 2020 •
edited
Loading

Some general fixes that mypy was complaining about and use a type-specialized function instead of visit to avoid dealing with Any everywhere. Also, executed "black" over the source.

@pablogsal pablogsal mentioned this pull request May 21, 2020
Merged
@pablogsal pablogsal force-pushed the fix_mypy branch 2 times, most recently from e1aa8e2 to 3f8bbc8 Compare May 21, 2020 20:00
lysnikolaou
lysnikolaou approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't even know about field, really nice. LGTM!

@lysnikolaou lysnikolaou added the needs backport to 3.9 only security fixes label May 21, 2020
@pablogsal pablogsal merged commit d10fef3 into python:master May 21, 2020
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the fix_mypy branch May 21, 2020 20:39
@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d10fef35c6ce8a3193b974be7e8c8304b1146153 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 21, 2020
@bedevere-bot
Copy link

GH-20300 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request May 21, 2020
@pablogsal
[3.9] Fix typing problems reported by mypy in pegen (pythonGH-20297).
df0b4d4 
(cherry picked from commit d10fef3)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request May 21, 2020
@pablogsal
[3.9] Fix typing problems reported by mypy in pegen (GH-20297) (GH-20300
7178b1b 
)

(cherry picked from commit d10fef3)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@pablogsal @arturoescaip
Fix typing problems reported by mypy in pegen (pythonGH-20297)
7d18f8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@isidentical isidentical Awaiting requested review from isidentical

Assignees

@pablogsal pablogsal

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @miss-islington @bedevere-bot @lysnikolaou @the-knights-who-say-ni