Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate the PEG parser to pick up latest changes #20195

Merged
merged 1 commit into from
May 18, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented May 18, 2020

Automerge-Triggered-By: @pablogsal

@ambv
Copy link
Contributor

ambv commented May 18, 2020

Should I wait for this before cutting beta1? 🧐

@pablogsal
Copy link
Member Author

Should I wait for this before cutting beta1? 🧐

Yes, please! I was just going to ping you now :)

@pablogsal
Copy link
Member Author

This was caused by merging a PR that had an old version of the automatically-generated files in which the CI passed but it was not up-to-date.

@ambv
Copy link
Contributor

ambv commented May 18, 2020

Not urgent but try figuring out if we can ensure that those are never out-of-date for future releases. This sounds like a nasty thing to overlook.

@pablogsal
Copy link
Member Author

Not urgent but try figuring out if we can ensure that those are never out-of-date for future releases. This sounds like a nasty thing to overlook.

Will try to think about that but sadly, other automatically-regenerated files have the same problem, is just that the PEG parser is being updated more often. IIRC there was some discussion about trying to ensure that all PRs are updated against master and the conclusion was that is not possible to do in an easy way :(

@ambv ambv merged commit ced4e5c into python:master May 18, 2020
@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@pablogsal pablogsal deleted the regen_pegen branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants