Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closes bpo-39953: Generate ifdefs around library code definitions. #19490

Merged
merged 1 commit into from
Apr 12, 2020
Merged

closes bpo-39953: Generate ifdefs around library code definitions. #19490

merged 1 commit into from
Apr 12, 2020

Conversation

benjaminp
Copy link
Contributor

@benjaminp benjaminp commented Apr 12, 2020 •
edited by bedevere-bot
Loading

@benjaminp benjaminp requested a review from tiran as a code owner April 12, 2020 18:40
@benjaminp benjaminp merged commit 909b87d into python:master Apr 12, 2020
@miss-islington
Copy link
Contributor

Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@benjaminp benjaminp deleted the fix-library-codes branch April 12, 2020 18:59
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 12, 2020
@benjaminp @miss-islington
closes bpo-39953: Generate ifdefs around library code definitions. (p…
56d6211 
…ythonGH-19490)

(cherry picked from commit 909b87d)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
@bedevere-bot
Copy link

GH-19491 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Apr 12, 2020
miss-islington added a commit that referenced this pull request Apr 12, 2020
@miss-islington @benjaminp
closes bpo-39953: Generate ifdefs around library code definitions. (G…
f35e7d3 
…H-19490)

(cherry picked from commit 909b87d)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjaminp @miss-islington @bedevere-bot @the-knights-who-say-ni