Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] Give proper credits for the memoryview implementation. (GH-18626) #18643

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

miss-islington
Copy link
Contributor

(cherry picked from commit ee3bac4)

Co-authored-by: Stefan Krah skrah@bytereef.org

(cherry picked from commit ee3bac4)

Co-authored-by: Stefan Krah <skrah@bytereef.org>
@miss-islington
Copy link
Contributor Author

@skrah: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@skrah: Status check is done, and it's a success ✅ .

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #18643 into 3.7 will increase coverage by 1.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              3.7   #18643       +/-   ##
===========================================
+ Coverage   81.94%   83.25%    +1.30%     
===========================================
  Files        1869     1571      -298     
  Lines      543653   414836   -128817     
  Branches    41730    44457     +2727     
===========================================
- Hits       445507   345379   -100128     
+ Misses      89025    59801    -29224     
- Partials     9121     9656      +535     
Impacted Files Coverage Δ
Lib/test/test_binhex.py 13.33% <0.00%> (-80.22%) ⬇️
Lib/binhex.py 17.84% <0.00%> (-58.61%) ⬇️
Lib/threading.py 47.43% <0.00%> (-32.13%) ⬇️
Lib/test/test_tuple.py 69.58% <0.00%> (-29.15%) ⬇️
Lib/test/test_ntpath.py 70.71% <0.00%> (-18.21%) ⬇️
Lib/test/libregrtest/utils.py 82.97% <0.00%> (-11.76%) ⬇️
Lib/ntpath.py 66.23% <0.00%> (-11.66%) ⬇️
Lib/crypt.py 82.85% <0.00%> (-10.13%) ⬇️
Lib/statistics.py 87.23% <0.00%> (-9.03%) ⬇️
Lib/test/test_unicodedata.py 90.98% <0.00%> (-7.93%) ⬇️
... and 1302 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 097612a...19fe4e3. Read the comment docs.

@skrah skrah merged commit 3dc6961 into python:3.7 Feb 24, 2020
@bedevere-bot
Copy link

@skrah: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington miss-islington deleted the backport-ee3bac4-3.7 branch February 24, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants