-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-39379:sys.path[0] is already absolute path #18561
Conversation
NEWS entry is not needed for this change IMO. |
I have made the requested changes; please review again |
Thanks for making the requested changes! : please review the changes made to this pull request. |
Agreed, I'll add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, other than a minor point on grammar that was present in the original entry. Not critical, but I think we should address it.
Also, I think this should receive approval from @vstinner prior to merging, just to be sure (since he originally wrote the patch for this entry).
Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
I have merged the PR since it's minor. I have left the issue open due to question at https://bugs.python.org/issue39379#msg360333 , Thanks for the patch and review. |
https://bugs.python.org/issue39379