-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-72463: Fix Lib/ctypes/test_loading.py
so that test_find
reports skipped
#18312
Conversation
…rather than passed when no libraries to test are found.
I know this is not "urgent" - but it always struck me as strange that a function that always returns NULL - when something, at least once, is expected - should pass - when perhaps the function has failed every time . |
Lib/ctypes/test_loading.py
so that test_find
reports skippedLib/ctypes/test_loading.py
so that test_find
reports skipped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I fixed an error and removed a NEWS entry which is not required for such kind of changes.
Thanks @aixtools for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…skipped (pythonGH-18312) (cherry picked from commit 04d1000) Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>
GH-116136 is a backport of this pull request to the 3.12 branch. |
…skipped (pythonGH-18312) (cherry picked from commit 04d1000) Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>
GH-116137 is a backport of this pull request to the 3.11 branch. |
|
Fix
Lib/ctypes/test_loading.py
so thattest_find
reports skipped rather than passed when no libraries to test are found.Backport to 3.7 and 3.8 is requested.
https://bugs.python.org/issue28276