Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-72463: Fix Lib/ctypes/test_loading.py so that test_find reports skipped #18312

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

aixtools
Copy link
Contributor

@aixtools aixtools commented Feb 2, 2020

Fix Lib/ctypes/test_loading.py so that test_find reports skipped rather than passed when no libraries to test are found.

Backport to 3.7 and 3.8 is requested.

https://bugs.python.org/issue28276

…rather than

passed when no libraries to test are found.
@aixtools
Copy link
Contributor Author

I know this is not "urgent" - but it always struck me as strange that a function that always returns NULL - when something, at least once, is expected - should pass - when perhaps the function has failed every time .

@serhiy-storchaka serhiy-storchaka changed the title bpo-28276: Fix Lib/ctypes/test_loading.py so that test_find reports skipped gh-72463: Fix Lib/ctypes/test_loading.py so that test_find reports skipped Feb 28, 2024
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I fixed an error and removed a NEWS entry which is not required for such kind of changes.

@serhiy-storchaka serhiy-storchaka merged commit 04d1000 into python:main Feb 29, 2024
31 checks passed
@miss-islington-app
Copy link

Thanks @aixtools for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 29, 2024
…skipped (pythonGH-18312)

(cherry picked from commit 04d1000)

Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 29, 2024

GH-116136 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Feb 29, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 29, 2024
…skipped (pythonGH-18312)

(cherry picked from commit 04d1000)

Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 29, 2024

GH-116137 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 29, 2024
serhiy-storchaka pushed a commit that referenced this pull request Feb 29, 2024
… skipped (GH-18312) (GH-116136)

(cherry picked from commit 04d1000)

Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull request Feb 29, 2024
… skipped (GH-18312) (GH-116137)

(cherry picked from commit 04d1000)

Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.11 has failed when building commit 8643cfd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1007/builds/1416) and take a look at the build logs.
  4. Check if the failure is related to this commit (8643cfd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1007/builds/1416

Summary of the results of the build (if available):

==

Click to see traceback logs
remote: Enumerating objects: 6, done.        
remote: Counting objects:  16% (1/6)        
remote: Counting objects:  33% (2/6)        
remote: Counting objects:  50% (3/6)        
remote: Counting objects:  66% (4/6)        
remote: Counting objects:  83% (5/6)        
remote: Counting objects: 100% (6/6)        
remote: Counting objects: 100% (6/6), done.        
remote: Compressing objects:  25% (1/4)        
remote: Compressing objects:  50% (2/4)        
remote: Compressing objects:  75% (3/4)        
remote: Compressing objects: 100% (4/4)        
remote: Compressing objects: 100% (4/4), done.        
remote: Total 6 (delta 2), reused 5 (delta 2), pack-reused 0        
From https://github.com/python/cpython
 * branch                  3.11       -> FETCH_HEAD
Note: switching to '8643cfd9183b390a5b230f78737b7f65c50200f4'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 8643cfd918 [3.11] gh-72463: Fix ctypes/test_loading.py so that test_find reports skipped (GH-18312) (GH-116137)
Switched to and reset branch '3.11'

configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

renaming build/scripts-3.11/pydoc3 to build/scripts-3.11/pydoc3.11
renaming build/scripts-3.11/idle3 to build/scripts-3.11/idle3.11
renaming build/scripts-3.11/2to3 to build/scripts-3.11/2to3-3.11

renaming build/scripts-3.11/pydoc3 to build/scripts-3.11/pydoc3.11
renaming build/scripts-3.11/idle3 to build/scripts-3.11/idle3.11
renaming build/scripts-3.11/2to3 to build/scripts-3.11/2to3-3.11

renaming build/scripts-3.11/pydoc3 to build/scripts-3.11/pydoc3.11
renaming build/scripts-3.11/idle3 to build/scripts-3.11/idle3.11
renaming build/scripts-3.11/2to3 to build/scripts-3.11/2to3-3.11
make: *** [Makefile:1846: buildbottest] Error 3

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants