Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39342: Expose X509_V_FLAG_ALLOW_PROXY_CERTS in ssl module #18011

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

chrisburr
Copy link
Contributor

@chrisburr chrisburr commented Jan 15, 2020

Exposes the X509_V_FLAG_ALLOW_PROXY_CERTS constant as ssl.VERIFY_ALLOW_PROXY_CERTS to allow for proxy certificate validation as described in: https://www.openssl.org/docs/man1.1.1/man7/proxy-certificates.html

https://bugs.python.org/issue39342

Automerge-Triggered-By: GH:tiran

@tiran
Copy link
Member

tiran commented Jan 15, 2020

Thanks, your patch looks good to me.

I cannot approve the PR at the moment. GH request fails with Personal token required for this feature. I'll look into the matter later.

@chrisburr
Copy link
Contributor Author

@tiran Sorry to pester you, but could you take a look when you get a chance?

I'm fairly sure Travis CI failed due to a network glitch.

@chaen
Copy link
Contributor

chaen commented Aug 28, 2020

I too would like to see this PR be merged. Is there anything I can do to help ?

@terryjreedy
Copy link
Member

The bogus review requests and CLA report are likely a result of force-pushing. This should not be be used when git merge origin/master is all that is needed.

@brettcannon brettcannon removed their request for review December 9, 2020 17:37
@chrisburr
Copy link
Contributor Author

I accidentally rebased on my fork's master instead of python/cpython which seems to have triggered GitHub to automatically request a review from many people. Sorry for the trouble.

@vsajip vsajip removed their request for review December 14, 2020 10:19
@methane methane removed their request for review March 18, 2021 07:17
@miss-islington miss-islington merged commit e0b4aa0 into python:master Mar 18, 2021
@chrisburr chrisburr deleted the fix-issue-39342 branch March 18, 2021 09:15
jab added a commit to jab/cpython that referenced this pull request Mar 20, 2021
* master: (129 commits)
  bpo-43452: Micro-optimizations to PyType_Lookup (pythonGH-24804)
  bpo-43517: Fix false positive in detection of circular imports (python#24895)
  bpo-43494: Make some minor changes to lnotab notes (pythonGH-24861)
  Mention that code.co_lnotab is deprecated in what's new for 3.10. (python#24902)
  bpo-43244: Remove symtable.h header file (pythonGH-24910)
  bpo-43466: Add --with-openssl-rpath configure option (pythonGH-24820)
  Fix a typo in c-analyzer (pythonGH-24468)
  bpo-41561: Add workaround for Ubuntu's custom security level (pythonGH-24915)
  bpo-43521: Allow ast.unparse with empty sets and NaN (pythonGH-24897)
  bpo-43244: Remove the PyAST_Validate() function (pythonGH-24911)
  bpo-43541: Fix PyEval_EvalCodeEx() regression (pythonGH-24918)
  bpo-43244: Fix test_peg_generators on Windows (pythonGH-24913)
  bpo-39342: Expose X509_V_FLAG_ALLOW_PROXY_CERTS in ssl module (pythonGH-18011)
  bpo-43244: Fix test_peg_generator for PyAST_Validate() (pythonGH-24912)
  bpo-42128: Add 'missing :' syntax error message to match statements (pythonGH-24733)
  bpo-43244: Add pycore_ast.h header file (pythonGH-24908)
  bpo-43244: Rename pycore_ast.h to pycore_ast_state.h (pythonGH-24907)
  Remove unnecessary imports in the grammar parser (pythonGH-24904)
  bpo-35883: Py_DecodeLocale() escapes invalid Unicode characters (pythonGH-24843)
  Add PEP 626 to what's new in 3.10. (python#24892)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants