Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-39299: Add more tests for mimetypes and its cli. (GH-17949) #17992

Merged
merged 1 commit into from
Feb 11, 2020
Merged

[3.8] bpo-39299: Add more tests for mimetypes and its cli. (GH-17949) #17992

merged 1 commit into from
Feb 11, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 13, 2020 •
edited by bedevere-bot
Loading

  • Add tests for case insensitive check of types and extensions as fallback.
  • Add tests for data url with no comma.
  • Add tests for read_mime_types.
  • Add tests for the mimetypes cli and refactor main code to private function.
  • Restore mimetypes.knownfiles value at the end of the test.
    (cherry picked from commit d8efc14)

Co-authored-by: Karthikeyan Singaravelan tir.karthi@gmail.com

https://bugs.python.org/issue39299

@tirkarthi @miss-islington
bpo-39299: Add more tests for mimetypes and its cli. (pythonGH-17949)
094bd63 
* Add tests for case insensitive check of types and extensions as fallback.
* Add tests for data url with no comma.
* Add tests for read_mime_types.
* Add tests for the mimetypes cli and refactor __main__ code to private function.
* Restore mimetypes.knownfiles value at the end of the test.
(cherry picked from commit d8efc14)

Co-authored-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
@miss-islington miss-islington requested a review from a team as a code owner January 13, 2020 18:25
@bedevere-bot bedevere-bot mentioned this pull request Jan 13, 2020
Merged
@miss-islington
Copy link
Contributor Author

@tirkarthi: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington
Copy link
Contributor Author

@tirkarthi: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@tirkarthi: Status check is done, and it's a success ✅ .

@asvetlov
Copy link
Contributor

@tirkarthi if you (or I or somebody else) approve this PR -- Miss Islington will merge it if tests pass.
It allows approving a backport PR just after the bot creates it; if everything is ok you don't need to touch the PR anymore.
Otherwise, you'll get a GitHub notification that something was wrong and need your attention.

@tirkarthi
Copy link
Member

Got it. Is automerging backport on approval a new workflow I am missing? I was slightly surprised by it in one of backport PRs where the PR was merged as I approved it I guess.

@Mariatta
Copy link
Member

This is pre-existing workflow. Autobackports (created by miss-islington) still require approval from a core dev.

@tirkarthi
Copy link
Member

Thanks @Mariatta .

@tirkarthi
Copy link
Member

@ned-deily Would it be okay to merge this for 3.8?

@ned-deily
Copy link
Member

@tirkarthi That's not my call :) but my instinct would be to say it's OK since 3.8 is still rather early in its maintenance cycle.

@tirkarthi
Copy link
Member

Sure, I was new and just wondering if there is any strict guideline for these changes that are more test oriented. Thanks @ned-deily :)

@Mariatta
Copy link
Member

@tirkarthi if this looks good to you, please approve the PR so miss-islington can merge it

@tirkarthi
Copy link
Member

I am merging this since it's Python 3.8.2 and this will be a good change covering more cases. cc: @ambv

tirkarthi
tirkarthi approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington miss-islington merged commit d3f9fb2 into python:3.8 Feb 11, 2020
@miss-islington miss-islington deleted the backport-d8efc14-3.8 branch February 11, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

Assignees

@tirkarthi tirkarthi

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@miss-islington @asvetlov @tirkarthi @Mariatta @ned-deily @the-knights-who-say-ni @bedevere-bot