Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38704: Prevent installation on unsupported Windows versions #17950

Merged
merged 4 commits into from
May 17, 2022
Merged

bpo-38704: Prevent installation on unsupported Windows versions #17950

merged 4 commits into from
May 17, 2022

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Jan 11, 2020 •
edited by bedevere-bot
Loading

@ZackerySpytz ZackerySpytz requested a review from a team as a code owner January 11, 2020 06:39
@ZackerySpytz
Copy link
Contributor Author

I guess Py_WINVER et al. should be updated as well.

There was also some discussion on https://bugs.python.org/issue32592 w.r.t. dropping Windows < 8.1.

@zooba
Copy link
Member

zooba commented Jan 14, 2020

@ZackerySpytz I think you're missing some changes to msi\bundle\Default.wxl for the updated string references.

Have you been able to build the MSI? It should pull down any dependencies automatically and be fairly straightforward if you run the tools/msi/build.bat script.

@zooba zooba self-assigned this Jan 14, 2020
@csabella
Copy link
Contributor

@ZackerySpytz, please address the code review. Thanks!

@zooba zooba closed this Jul 4, 2020
@zooba zooba reopened this Jul 4, 2020
@zooba
Copy link
Member

zooba commented Jul 4, 2020

Closed/reopened to run the MSI checks, which I added after this PR was created.

@zooba zooba added the needs backport to 3.9 only security fixes label Jul 4, 2020
@zooba
Copy link
Member

zooba commented Jul 4, 2020

We still need the string added to Tools\msi\bundle\Default.wxl. It will compile fine because it's a runtime reference to the string - we'll only see a failure when run on a Win<=8 system.

@ZackerySpytz
Copy link
Contributor Author

I have updated Tools\msi\bundle\Default.wxl.

@ambv
Copy link
Contributor

ambv commented May 17, 2022

This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today.

@ambv ambv removed the needs backport to 3.9 only security fixes label May 17, 2022
@zooba zooba added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels May 17, 2022
@zooba zooba merged commit 6b932cb into python:main May 17, 2022
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 17, 2022
@ZackerySpytz @miss-islington
bpo-38704: Prevent installation on unsupported Windows versions (pyth…
537732d 
…onGH-17950)

(cherry picked from commit 6b932cb)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

GH-92902 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 17, 2022
@bedevere-bot
Copy link

GH-92903 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 17, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 17, 2022
@ZackerySpytz @miss-islington
bpo-38704: Prevent installation on unsupported Windows versions (pyth…
28483b4 
…onGH-17950)

(cherry picked from commit 6b932cb)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@zooba
Copy link
Member

zooba commented May 17, 2022

Looks like after I resolved the conflicts, it was because we already had a good fix for this 😆 Oh well, no harm done. I won't backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zooba zooba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ZackerySpytz @zooba @csabella @ambv @miss-islington @bedevere-bot @the-knights-who-say-ni