Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: fix MinGW library generation command #17917

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Conversation

Baljak
Copy link
Contributor

@Baljak Baljak commented Jan 9, 2020

To print the exports to stdout, the gendef command requires the option "-". Without this option, no output is generated.

To print the exports to stdout, the gendef command requires the option "-". Without this option, no output is generated.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Baljak

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@csabella
Copy link
Contributor

csabella commented Feb 3, 2020

@Baljak, please sign the CLA as per the comment above. Thank you!

@Baljak
Copy link
Contributor Author

Baljak commented Feb 3, 2020

@Baljak, please sign the CLA as per the comment above. Thank you!

Sorry but I'm unable to create a b.p.o account. I tried several times but I never received the confirmation email so I gave up (I checked my spam folder and it isn't there).

There is an issue about this: python/psf-infra-meta#55

@zooba
Copy link
Member

zooba commented Feb 5, 2020

This is so trivial I'm happy to merge without the CLA.

@zooba zooba merged commit 2545fa8 into python:master Feb 5, 2020
@miss-islington
Copy link
Contributor

Thanks @Baljak for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 5, 2020
To print the exports to stdout, the gendef command requires the option "-". Without this option, no output is generated.
(cherry picked from commit 2545fa8)

Co-authored-by: Baljak <baljci@hotmail.com>
@bedevere-bot
Copy link

GH-18352 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Feb 5, 2020
@miss-islington
Copy link
Contributor

Sorry, @Baljak and @zooba, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2545fa87628b4caca519da8aeb0eeef368b9dc0d 3.7

JulienPalard pushed a commit that referenced this pull request Feb 6, 2020
To print the exports to stdout, the gendef command requires the option "-". Without this option, no output is generated.
(cherry picked from commit 2545fa8)

Co-authored-by: Baljak <baljci@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants