Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38899: virtual environment activation for fish should use source #17359

Merged
merged 1 commit into from
Nov 23, 2019
Merged

bpo-38899: virtual environment activation for fish should use source #17359

merged 1 commit into from
Nov 23, 2019

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Nov 22, 2019 •
edited by miss-islington
Loading

The previously documented use of . is considered deprecated (https://fishshell.com/docs/current/commands.html#source).

https://bugs.python.org/issue38899

Automerge-Triggered-By: @brettcannon

@brettcannon brettcannon added needs backport to 3.6 needs backport to 3.8 only security fixes docs Documentation in the Doc dir labels Nov 23, 2019
@miss-islington miss-islington merged commit 84b1ff6 into python:master Nov 23, 2019
@miss-islington
Copy link
Contributor

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry @brettcannon, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 84b1ff65609c5910b4f838adbe1ead83baae7dbf 3.8

@miss-islington miss-islington self-assigned this Nov 23, 2019
@miss-islington
Copy link
Contributor

Sorry, @brettcannon, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 84b1ff65609c5910b4f838adbe1ead83baae7dbf 3.7

@miss-islington
Copy link
Contributor

Sorry @brettcannon, I had trouble checking out the 3.6 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 84b1ff65609c5910b4f838adbe1ead83baae7dbf 3.6

@brettcannon brettcannon deleted the fish-activation branch November 23, 2019 20:59
@brettcannon
Copy link
Member Author

I'm not motivated enough to backport this since it's such a minor documentation update, but if someone else felt like it I would be happy to merge it.

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@brettcannon
bpo-38899: virtual environment activation for fish should use source (
b36e437 
pythonGH-17359)

The previously documented use of `.` is considered deprecated (https://fishshell.com/docs/current/commands.html#source).


https://bugs.python.org/issue38899



Automerge-Triggered-By: @brettcannon
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@brettcannon @shihai1991
bpo-38899: virtual environment activation for fish should use source (
dc58c22 
pythonGH-17359)

The previously documented use of `.` is considered deprecated (https://fishshell.com/docs/current/commands.html#source).


https://bugs.python.org/issue38899



Automerge-Triggered-By: @brettcannon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip vsajip approved these changes

@eamanu eamanu eamanu approved these changes

Assignees

@miss-islington miss-islington

Labels
docs Documentation in the Doc dir needs backport to 3.8 only security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brettcannon @miss-islington @vsajip @eamanu @the-knights-who-say-ni @bedevere-bot