Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-4630: Add cursor no-blink option for IDLE #16960

Merged
merged 10 commits into from
Nov 13, 2019
Merged

bpo-4630: Add cursor no-blink option for IDLE #16960

merged 10 commits into from
Nov 13, 2019

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Oct 28, 2019 •
edited by bedevere-bot
Loading

Add an option to toggle IDLE's cursor blink.

Co-Authored-By: Guilherme Polo ggpolo@gmail.com
Co-Authored-By: Roger Serwy roger.serwy@gmail.com

https://bugs.python.org/issue4630

@ZackerySpytz @gpolo @serwy
bpo-4630: A cursor blink option for IDLE
3febbc6 
Add an option to toggle IDLE's cursor blink.

Co-Authored-By: Guilherme Polo <ggpolo@gmail.com>
Co-Authored-By: Roger Serwy <roger.serwy@gmail.com>
terryjreedy
terryjreedy requested changes Oct 31, 2019
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for converting this overdue, overlooked patch. I realize that adjusting the 9-year-old code to the highly revised configdialog was very much not 'cut and paste'.

AFAICT, the code works and changes properly persist between sessions.

After the revisions, a new test should be added to test_configdialog. I expect to write but you can try if you want.

I want this merged in November for the December releases, so ping if I let this go more than a week after revision.

Lib/idlelib/configdialog.py Outdated Show resolved Hide resolved
Lib/idlelib/configdialog.py Outdated Show resolved Hide resolved
Lib/idlelib/editor.py Outdated Show resolved Hide resolved
Lib/idlelib/editor.py Outdated Show resolved Hide resolved
Lib/idlelib/editor.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ZackerySpytz
Copy link
Contributor Author

Thank you, @terryjreedy, for the thorough review. I believe I have addressed all of
your comments.

I was unsure if the cursor-blink config option in config-main.def should be moved.

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@ZackerySpytz
Copy link
Contributor Author

@terryjreedy Ping.

terryjreedy
terryjreedy approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I noted on the issue, the original news item was not true, but the reduced claim is. Storing insertofftime on idleConf will make a 2nd patch much easier.

The new update_cursor_blink was tested manually, though a unittest should be added.

@terryjreedy terryjreedy changed the title bpo-4630: A cursor blink option for IDLE bpo-4630: Add cursor no-blink option for IDLE Nov 13, 2019
@terryjreedy terryjreedy merged commit 9c28449 into python:master Nov 13, 2019
@terryjreedy terryjreedy added needs backport to 3.8 only security fixes type-feature A feature request or enhancement labels Nov 13, 2019
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Nov 13, 2019
@bedevere-bot
Copy link

GH-17141 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-17142 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2019
@ZackerySpytz @miss-islington
bpo-4630: Add cursor no-blink option for IDLE (pythonGH-16960)
84c12a2 
This immediately toggles shell, editor, and output windows, but does not affect other input widgets.
(cherry picked from commit 9c28449)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Nov 13, 2019
@miss-islington @ZackerySpytz
bpo-4630: Add cursor no-blink option for IDLE (GH-16960)
a67bc10 
This immediately toggles shell, editor, and output windows, but does not affect other input widgets.
(cherry picked from commit 9c28449)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Nov 13, 2019
@miss-islington @ZackerySpytz
bpo-4630: Add cursor no-blink option for IDLE (GH-16960)
753d0c0 
This immediately toggles shell, editor, and output windows, but does not affect other input widgets.
(cherry picked from commit 9c28449)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@ZackerySpytz
bpo-4630: Add cursor no-blink option for IDLE (pythonGH-16960)
adf005a 
This immediately toggles shell, editor, and output windows, but does not affect other input widgets.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@ZackerySpytz @shihai1991
bpo-4630: Add cursor no-blink option for IDLE (pythonGH-16960)
a63bdb3 
This immediately toggles shell, editor, and output windows, but does not affect other input widgets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZackerySpytz @bedevere-bot @miss-islington @terryjreedy @the-knights-who-say-ni