bpo-28494: Test existing zipfile working behavior.

[gpshead]

Adds unittests for executables with a zipfile appended to test_zipfile
as zipfile.is_zipfile and zipfile.ZipFile work properly on these today.

This is being added as a regression test that #5053 would otherwise fail today.

https://bugs.python.org/issue28494

[gpshead]

duh, fixing the test to skip the execute one on windows :)

[Yhg1s]

How about using shutil.which('bash') instead? There are some windows machines with bash installed now... will the test work there?

[gpshead]

I didn't think windows supported #! line executables as a concept. executable is based on filename ending in bat/cmd/com/exe, not an execute bit there.

[miss-islington]

Thanks @gpshead for the PR, and @Yhg1s for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

[bedevere-bot]

GH-15891 is a backport of this pull request to the 3.8 branch.

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.8 has failed when building commit 74b0291.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/230/builds/317) and take a look at the build logs.
4. Check if the failure is related to this commit (74b0291) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/230/builds/317

Failed tests:

• test_zipfile

Failed subtests:

• test_read_zip64_with_exe_prepended - test.test_zipfile.TestExecutablePrependedZip
• test_read_zip_with_exe_prepended - test.test_zipfile.TestExecutablePrependedZip
• test_execute_zip64 - test.test_zipfile.TestExecutablePrependedZip
• test_execute_zip2 - test.test_zipfile.TestExecutablePrependedZip

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

411 tests OK.

1 test failed:
test_zipfile

11 tests skipped:
test_asdl_parser test_clinic test_devpoll test_gdb test_kqueue
test_msilib test_startfile test_winconsoleio test_winreg
test_winsound test_zipfile64

1 re-run test:
test_zipfile

Total duration: 24 min 26 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/test/test_zipfile.py", line 2469, in test_read_zip64_with_exe_prepended
    self._test_zip_works(self.exe_zip64)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/test/test_zipfile.py", line 2457, in _test_zip_works
    self.assertTrue(zipfile.is_zipfile(name),
AssertionError: False is not true : is_zipfile failed on ziptestdata/exe_with_z64


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/test/test_zipfile.py", line 2482, in test_execute_zip64
    output = subprocess.check_output([self.exe_zip64, sys.executable])
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/subprocess.py", line 411, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/subprocess.py", line 489, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/subprocess.py", line 845, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/subprocess.py", line 1689, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'ziptestdata/exe_with_z64'


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/test/test_zipfile.py", line 2466, in test_read_zip_with_exe_prepended
    self._test_zip_works(self.exe_zip)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/test/test_zipfile.py", line 2457, in _test_zip_works
    self.assertTrue(zipfile.is_zipfile(name),
AssertionError: False is not true : is_zipfile failed on ziptestdata/exe_with_zip


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/test/test_zipfile.py", line 2475, in test_execute_zip2
    output = subprocess.check_output([self.exe_zip, sys.executable])
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/subprocess.py", line 411, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/subprocess.py", line 489, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/subprocess.py", line 845, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/subprocess.py", line 1689, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'ziptestdata/exe_with_zip'

[Yhg1s]

Buildbot failure should have been fixed by GH-15902.