Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-29505: Fuzz json module, enforce size limit on int(x) fuzz #13991

Merged
merged 2 commits into from
Jun 12, 2019

Conversation

ammaraskar
Copy link
Member

@ammaraskar ammaraskar commented Jun 11, 2019

Since CPython seems to be successfully building and being fuzzed in OSS-Fuzz, it's time to add some more interesting fuzzing targets. This PR does the following:

  • Add a size limit on the int(x) fuzz target. Since python supports arbitrarily large integers, there is a rather
    boring case that is essentially int("9" * 100000) causing timeouts in this path.
  • Submit json.loads(x) for fuzzing.

Potential reviewers: @gpshead @alex (skip-news label can be applied)

https://bugs.python.org/issue29505

Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, let the fuzzy fun begin!

@gpshead gpshead merged commit a6e190e into python:master Jun 12, 2019
@miss-islington
Copy link
Contributor

Thanks @ammaraskar for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-14005 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Jun 12, 2019
@bedevere-bot
Copy link

GH-14006 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2019
…nGH-13991)

* bpo-29505: Enable fuzz testing of the json module, enforce size limit on int(x) fuzz and json input size to avoid timeouts.

Contributed by by Ammar Askar for Google.
(cherry picked from commit a6e190e)

Co-authored-by: Ammar Askar <aaskar@google.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2019
…nGH-13991)

* bpo-29505: Enable fuzz testing of the json module, enforce size limit on int(x) fuzz and json input size to avoid timeouts.

Contributed by by Ammar Askar for Google.
(cherry picked from commit a6e190e)

Co-authored-by: Ammar Askar <aaskar@google.com>
miss-islington added a commit that referenced this pull request Jun 12, 2019
)

* bpo-29505: Enable fuzz testing of the json module, enforce size limit on int(x) fuzz and json input size to avoid timeouts.

Contributed by by Ammar Askar for Google.
(cherry picked from commit a6e190e)

Co-authored-by: Ammar Askar <aaskar@google.com>
miss-islington added a commit that referenced this pull request Jun 12, 2019
)

* bpo-29505: Enable fuzz testing of the json module, enforce size limit on int(x) fuzz and json input size to avoid timeouts.

Contributed by by Ammar Askar for Google.
(cherry picked from commit a6e190e)

Co-authored-by: Ammar Askar <aaskar@google.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
…nGH-13991)

* bpo-29505: Enable fuzz testing of the json module, enforce size limit on int(x) fuzz and json input size to avoid timeouts.

Contributed by by Ammar Askar for Google.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
…nGH-13991)

* bpo-29505: Enable fuzz testing of the json module, enforce size limit on int(x) fuzz and json input size to avoid timeouts.

Contributed by by Ammar Askar for Google.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants