bpo-29505: Fix interpreter in fuzzing targets to be relocatable #13907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangrisano
reviewed
Jun 8, 2019
|
Hi. Thank you for the pull request. I left a comment about the change. |
gpshead
added
skip news
needs backport to 3.7
needs backport to 3.8
|
Thanks @ammaraskar for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-13914 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 8, 2019
…onGH-13907) (cherry picked from commit a15a7bc) Co-authored-by: Ammar Askar <ammar@ammaraskar.com>
|
GH-13915 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Jun 8, 2019
miss-islington
added a commit
that referenced
this pull request
Jun 8, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get python fully checked into oss-fuzz, see google/oss-fuzz#2493 and the abandoned google/oss-fuzz#731
One of the concerns in the old pull request was that the python build will be moved from the
--prefixit is installed in to another directory. This was causing the fuzz targets (which are essentially just programs with embedded python interpreters) to throw:As it turns out the fuzz targets were missing a call to
Py_SetProgramNamewhich is what _testembed.c does. I am not an expert in the import machinery at all but I'm assuming thePy_SetProgramNamecall is essential to setting up the right prefixes internally as the docs somewhat suggest:If so, the docs can probably be improved in this regard.
Potential reviewers: @gpshead @alex (skip-news label can be applied)
https://bugs.python.org/issue29505