Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). (gh-13714)" #13780

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Revert "bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). (gh-13714)" #13780

merged 1 commit into from
Jun 3, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 3, 2019 •
edited by bedevere-bot
Loading

@ericsnowcurrently
Copy link
Member

Please wait. :) I'm going to take a look.

@vstinner
Copy link
Member Author

vstinner commented Jun 3, 2019

Please wait. :) I'm going to take a look.

There is a release scheduled for today. Nobody is able to reproduce nor debug the issue. The change was pushed 2 days ago: the buildbot policy says that you have 24h to fix regressions:
https://pythondev.readthedocs.io/ci.html#revert-on-fail

Sorry but we are busy enough with enough other bugs:
https://mail.python.org/pipermail/python-dev/2019-June/157826.html

I don't want to have to investigate this issue. Moreover, this bug is known for months: see https://bugs.python.org/issue33608 history.

The only motivation for the revert is to repair the CI. It doesn't mean that your change is wrong.

Your change doesn't have to be in the master branch to be able to investigate: use "git checkout 6a150bc" to get it.

@vstinner
Copy link
Member Author

vstinner commented Jun 3, 2019

I don't want to have to investigate this issue.

Hum, to be clear, I already spent 2 hours today to attempt to investigate this issue, Pablo also investigated the issue:

ericsnowcurrently
ericsnowcurrently approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in the tracker, I agree that this should be reverted for the sake of the beta 1 release.

@ericsnowcurrently
Copy link
Member

Thanks for again spending time trying to figure this out! The worst thing for me is wasting other people's time.

@vstinner vstinner merged commit e225beb into python:master Jun 3, 2019
@vstinner vstinner deleted the revert_pending branch June 3, 2019 16:34
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@vstinner @DinoV
Revert "bpo-33608: Factor out a private, per-interpreter _Py_AddPendi…
a405d90 
…ngCall(). (pythongh-13714)" (pythonGH-13780)

This reverts commit 6a150bc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot