Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36275: enhance documentation for venv.create() #13114

Merged
merged 3 commits into from
May 6, 2019
Merged

bpo-36275: enhance documentation for venv.create() #13114

merged 3 commits into from
May 6, 2019

Conversation

skoslowski
Copy link
Contributor

@skoslowski skoslowski commented May 6, 2019 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 6, 2019
tirkarthi
tirkarthi requested changes May 6, 2019
View reviewed changes
Doc/library/venv.rst Show resolved Hide resolved
@JulienPalard
Copy link
Member

You may also add a versionadded for the prompt paramter while we're at it.

tirkarthi
tirkarthi approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution :)

csabella
csabella approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csabella csabella merged commit 3921b1c into python:master May 6, 2019
@miss-islington
Copy link
Contributor

Thanks @skoslowski for the PR, and @csabella for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 6, 2019
@skoslowski @miss-islington
bpo-36275: enhance documentation for venv.create() (pythonGH-13114)
e59fe06 
(cherry picked from commit 3921b1c)

Co-authored-by: Sebastian Koslowski <sebastian.koslowski@gmail.com>
@bedevere-bot
Copy link

GH-13131 is a backport of this pull request to the 3.7 branch.

@csabella
Copy link
Contributor

csabella commented May 6, 2019

Thanks @skoslowski for the PR and @tirkarthi and @JulienPalard for the review. 🎉

miss-islington added a commit that referenced this pull request May 6, 2019
@miss-islington @skoslowski
bpo-36275: enhance documentation for venv.create() (GH-13114)
9a03c77 
(cherry picked from commit 3921b1c)

Co-authored-by: Sebastian Koslowski <sebastian.koslowski@gmail.com>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request May 7, 2019
@CuriousLearner
Merge branch 'master' into fix-25439
2cb5fd7 
* master: (1204 commits)
  bpo-31855: unittest.mock.mock_open() results now respects the argument of read([size]) (pythonGH-11521)
  Forbid creating of stream objects outside of asyncio (python#13101)
  bpo-35925: Skip SSL tests that fail due to weak external certs. (pythonGH-13124)
  Fix rst formatting for several links in ssl documentation (pythonGH-13133)
  bpo-36542: Allow to overwrite the signature for Python functions. (pythonGH-12705)
  bpo-36793: Remove unneeded __str__ definitions. (pythonGH-13081)
  bpo-36766: Typos in docs and code comments (pythonGH-13116)
  bpo-36275: enhance documentation for venv.create() (pythonGH-13114)
  Clarify the download unit in the download section (pythonGH-13122)
  bpo-30668: add missing word in license.rst (pythonGH-13115)
  Unroll import-team in CODEOWNERS (python#13118)
  bpo-36594: Fix incorrect use of %p in format strings (pythonGH-12769)
  bpo-36798: Updating f-string docs for := use case (pythonGH-13107)
  Update wsgiref.rst (python#10488)
  Doc/c-api/exceptions.rst: fix grammar (python#12091)
  bpo-36811: Fix a C compiler warning in _elementtree.c. (pythonGH-13109)
  Only count number of members once (python#12691)
  bpo-16024: Doc cleanup regarding path_fd, dir_fd, follow_symlinks (pythonGH-5505)
  bpo-36791: Safer detection of integer overflow in sum(). (pythonGH-13080)
  bpo-33530: Implement Happy Eyeballs in asyncio, v2 (pythonGH-7237)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@csabella csabella csabella approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@skoslowski @the-knights-who-say-ni @JulienPalard @miss-islington @bedevere-bot @csabella @tirkarthi