Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in comments #123201

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Fix typos in comments #123201

merged 2 commits into from
Aug 21, 2024

Conversation

Wulian233
Copy link
Contributor

skip news and issues

AlexWaygood
AlexWaygood requested changes Aug 21, 2024
View reviewed changes
Lib/tkinter/__init__.py Outdated Show resolved Hide resolved
Lib/tkinter/__init__.py Outdated Show resolved Hide resolved
Modules/_ctypes/_ctypes_test.c Outdated Show resolved Hide resolved
Lib/test/test_weakref.py Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented Aug 21, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Wulian233
Copy link
Contributor Author

please review again

AlexWaygood
AlexWaygood approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AlexWaygood AlexWaygood enabled auto-merge (squash) August 21, 2024 12:22
@AlexWaygood AlexWaygood merged commit 94036e4 into python:main Aug 21, 2024
36 of 37 checks passed
@Wulian233 Wulian233 deleted the typo branch August 21, 2024 12:57
@picnixz
Copy link
Contributor

picnixz commented Aug 21, 2024

@AlexWaygood Do you want to backport it?

@AlexWaygood
Copy link
Member

@AlexWaygood Do you want to backport it?

I don't think any of these changes are user-facing (except for maybe the tkinter docstring) so I'm not sure it's worth it, especially during a release-candidate period when we're meant to be aiming for stability above all else

@picnixz
Copy link
Contributor

picnixz commented Aug 21, 2024

Agreed. Let's keep it as a feature for 3.14.

blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@Wulian233 @blhsing
Fix typos in comments (python#123201)
4fcdde2
@Wulian233 Wulian233 mentioned this pull request Aug 29, 2024
Merged
@Wulian233 Wulian233 mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian gaogaotiantian is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wulian233 @picnixz @AlexWaygood