Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-122965: Fix reusable-change-detection.yml on workflow_dispatch #122966

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 13, 2024

We no longer skip Docs and Windows MSI jobs on workflow_trigger but instead they are now always executed on manual runs.

Refs #122336

@sobolevn
Copy link
Member Author

sobolevn commented Aug 13, 2024

@sobolevn
Copy link
Member Author

sobolevn commented Aug 13, 2024

One more point to consider: maybe instead we always need to run docs and windows msi jobs on workflow_dispatch: and not skip them?

Basically I propose to think about this change, from:

    - name: Check for docs changes
      if: >-
        github.event_name == 'pull_request'
        && steps.changed-docs-files.outputs.added_modified_renamed != ''
      id: docs-changes
      run: |
        echo "run-docs=true" >> "${GITHUB_OUTPUT}"

to:

    - name: Check for docs changes
      if: >-
        (github.event_name == 'pull_request'
           && steps.changed-docs-files.outputs.added_modified_renamed != '')
        || github.event_name == 'workflow_dispatch'
      id: docs-changes
      run: |
        echo "run-docs=true" >> "${GITHUB_OUTPUT}"

and the same for - name: Check for changes in MSI installer-related files

@sobolevn
Copy link
Member Author

Docs job didn't really work out:

https://github.com/sobolevn/cpython/actions/runs/10368635188/job/28702683326

Снимок экрана 2024-08-13 в 14 19 10

So, I addapted it.

@sobolevn
Copy link
Member Author

@sobolevn
Copy link
Member Author

Done, @hugovk! Thanks for your quick and helpful review! 👍

@webknjaz
Copy link
Contributor

Looks like the PR title/description needs updating.

@sobolevn
Copy link
Member Author

Failures are unrelated, GitHub was down. Re-running.

The manual build was succesful: https://github.com/sobolevn/cpython/actions/runs/10370346404/job/28708436891

@sobolevn
Copy link
Member Author

This looks complete now! GitHub re-run worked, local manual tests passed: https://github.com/sobolevn/cpython/actions/runs/10370346404/job/28708436891

Thanks everyone!

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk merged commit 6ae942f into python:main Aug 14, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2024
…patch` (pythonGH-122966)

(cherry picked from commit 6ae942f)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Aug 14, 2024

GH-123008 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 14, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2024
…patch` (pythonGH-122966)

(cherry picked from commit 6ae942f)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Aug 14, 2024

GH-123009 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Aug 14, 2024
sobolevn added a commit that referenced this pull request Aug 14, 2024
…spatch` (GH-122966) (#123009)

gh-122965: Fix `reusable-change-detection.yml` on `workflow_dispatch` (GH-122966)
(cherry picked from commit 6ae942f)

Co-authored-by: sobolevn <mail@sobolevn.me>
@hugovk
Copy link
Member

hugovk commented Aug 14, 2024

After merging, I tested a manual trigger and looks good: https://github.com/python/cpython/actions/runs/10387198512 👍

sobolevn added a commit that referenced this pull request Aug 14, 2024
…spatch` (GH-122966) (#123008)

gh-122965: Fix `reusable-change-detection.yml` on `workflow_dispatch` (GH-122966)
(cherry picked from commit 6ae942f)

Co-authored-by: sobolevn <mail@sobolevn.me>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants