Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36030: Improve performance of some tuple operations #12052

Merged
merged 3 commits into from
Aug 14, 2019
Merged

bpo-36030: Improve performance of some tuple operations #12052

merged 3 commits into from
Aug 14, 2019

Conversation

sir-sigurd
Copy link
Contributor

@sir-sigurd sir-sigurd commented Feb 26, 2019 •
edited by bedevere-bot
Loading

It seems to work, but I marked it as WIP, because it looks a bit ugly, I'll try to do something with it.

https://bugs.python.org/issue36030

eamanu
eamanu reviewed Feb 26, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, lgtm. Tonight, if any work on this, I will test it, and I will give you my depth opinion :-)

vstinner
vstinner reviewed Feb 26, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the fact that all changes are restricted to tupleobject.c.

Objects/tupleobject.c Outdated Show resolved Hide resolved
Objects/tupleobject.c Outdated Show resolved Hide resolved
Objects/tupleobject.c Outdated Show resolved Hide resolved
Objects/tupleobject.c Outdated Show resolved Hide resolved
Objects/tupleobject.c Outdated Show resolved Hide resolved
@sir-sigurd sir-sigurd force-pushed the tuple-untracked branch 2 times, most recently from ab67436 to 3d65669 Compare February 27, 2019 13:11
vstinner
vstinner reviewed Mar 1, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sir-sigurd Can you please add a few comments? See my review.

Objects/tupleobject.c Outdated Show resolved Hide resolved
@csabella
Copy link
Contributor

csabella commented Jun 5, 2019

@sir-sigurd, I'm not sure the status of this. Have you addressed all the review comments from @vstinner? If so, please add a note that this is ready for review again. Thanks!

@sir-sigurd
Copy link
Contributor Author

@csabella, it's still WIP, I need to add comments requested by @vstinner at least, I hope that I'll have time to finish it in the near future.

vstinner
vstinner reviewed Jun 5, 2019
View reviewed changes
Objects/tupleobject.c Outdated Show resolved Hide resolved
@sir-sigurd
Copy link
Contributor Author

@vstinner could you check it again? I reworked it a bit, hope it looks more sane now.

vstinner
vstinner reviewed Aug 12, 2019
View reviewed changes
Objects/tupleobject.c Show resolved Hide resolved
Objects/tupleobject.c Show resolved Hide resolved
Objects/tupleobject.c Outdated Show resolved Hide resolved
@sir-sigurd sir-sigurd changed the title bpo-36030: Improve performance of some tuple operations [WIP] bpo-36030: Improve performance of some tuple operations Aug 12, 2019
vstinner
vstinner requested changes Aug 14, 2019
View reviewed changes
Objects/tupleobject.c Outdated Show resolved Hide resolved
Objects/tupleobject.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

vstinner
vstinner approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit 4fa10dd into python:master Aug 14, 2019
@sir-sigurd sir-sigurd deleted the tuple-untracked branch August 14, 2019 15:45
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@sir-sigurd @lisroach
bpo-36030: Improve performance of some tuple operations (pythonGH-12052)
a111313
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@sir-sigurd @DinoV
bpo-36030: Improve performance of some tuple operations (pythonGH-12052)
2d81474
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@sir-sigurd @websurfer5
bpo-36030: Improve performance of some tuple operations (pythonGH-12052)
56a0bdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu left review comments

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sir-sigurd @csabella @bedevere-bot @vstinner @eamanu @the-knights-who-say-ni