Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to the itertools recipes #118563

Merged
merged 2 commits into from
May 3, 2024

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented May 3, 2024

  • Tighten docstrings and comments
  • Improve all_equal() example to not have a four that looked like an eight.
  • Replace variable name it with iterator which is clearer.
  • Removed early yield-from logic from sieve() because it made the code hard to decipher.
  • Replace unique_justseem() with set() in totient(). This is shorter, faster, clearer, and removes a dependency.
  • Replace variable name p with prime which is clearer.

📚 Documentation preview 📚: https://cpython-previews--118563.org.readthedocs.build/

@rhettinger rhettinger added docs Documentation in the Doc dir needs backport to 3.12 bug and security fixes labels May 3, 2024
@rhettinger rhettinger merged commit 6d9e8e9 into python:main May 3, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@rhettinger rhettinger deleted the minor_recipe_improvements branch May 3, 2024 22:07
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 3, 2024
(cherry picked from commit 6d9e8e9)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented May 3, 2024

GH-118565 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 3, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant