gh-116322: Enable the GIL while loading C extension modules #118560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swtaarrs
added
interpreter-core
|
!buildbot nogil |
|
🤖 New build scheduled with the buildbot fleet by @swtaarrs for commit 637c3e5 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
swtaarrs
requested review from
a team,
kumaraditya303,
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
|
I have a local commit to update |
colesbury
reviewed
May 3, 2024
swtaarrs
commented
May 6, 2024
ericsnowcurrently
approved these changes
May 6, 2024
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
…thon#118560) Add the ability to enable/disable the GIL at runtime, and use that in the C module loading code. We can't know before running a module init function if it supports free-threading, so the GIL is temporarily enabled before doing so. If the module declares support for running without the GIL, the GIL is later disabled. Otherwise, the GIL is permanently enabled, and will never be disabled again for the life of the current interpreter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on gh-116882, this PR adds the ability to enable/disable the GIL at runtime, and uses that in the C module loading code.
We can't know before running a module init function if it supports free-threading, so the GIL is temporarily enabled before doing so. If the module declares support for running without the GIL, the GIL is later disabled. Otherwise, the GIL is permanently enabled, and will never be disabled again for the life of the current interpreter.