Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-117657: Use clang 18 in TSAN builds #118533

Merged
merged 1 commit into from
May 7, 2024
Merged

gh-117657: Use clang 18 in TSAN builds #118533

merged 1 commit into from
May 7, 2024

Conversation

mpage
Copy link
Contributor

@mpage mpage commented May 3, 2024 •
edited by bedevere-app bot
Loading

We were using clang 14 which is a couple of years old.

@mpage
Use clang 18 in TSAN builds
5713566 
We were using clang 14 which is a couple of years old.
@bedevere-app bedevere-app bot mentioned this pull request May 3, 2024
Open
@mpage mpage added the skip news label May 3, 2024
@mpage mpage requested review from DinoV and colesbury May 3, 2024 03:36
@mpage mpage marked this pull request as ready for review May 3, 2024 03:36
@colesbury
Copy link
Contributor

Does the version matter? I've been using gcc 11.4 locally and haven't run into issues yet.

@mpage
Copy link
Contributor Author

mpage commented May 3, 2024

The main motivation is that we get a newer llvm-symbolizer for use in TSAN, which gives us (slightly) more helpful error messages. For example, instead of

LLVMSymbolizer: error reading file: No such file or directory

we get

/usr/bin/llvm-symbolizer-18: error: '[stack]': No such file or directory

@colesbury colesbury requested a review from corona10 May 3, 2024 15:52
corona10
corona10 approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@encukou
Copy link
Member

encukou commented May 7, 2024

I hope apt.llvm.org won't go down as often as Launchpad :)

@encukou encukou merged commit 3a6ff1b into python:main May 7, 2024
35 checks passed
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@mpage @SonicField
pythongh-117657: Use clang 18 in TSAN builds (pythonGH-118533)
101d9c7 
Use clang 18 in TSAN builds

We were using clang 14 which is a couple of years old.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@corona10 corona10 corona10 approved these changes

@DinoV DinoV Awaiting requested review from DinoV

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpage @colesbury @encukou @corona10