Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118406: Add signature for sqlite3.Connection objects #118428

Merged
merged 2 commits into from
Apr 30, 2024
Merged

gh-118406: Add signature for sqlite3.Connection objects #118428

merged 2 commits into from
Apr 30, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 30, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 30, 2024
Closed
@erlend-aasland erlend-aasland linked an issue Apr 30, 2024 that may be closed by this pull request
Implement inspect.signature() for sqlite3 connection object #118406
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Proposed a minor style change.

Modules/_sqlite/connection.c Outdated Show resolved Hide resolved
Modules/_sqlite/connection.c Outdated Show resolved Hide resolved
@erlend-aasland @serhiy-storchaka
Apply suggestions from code review
3e75ac6 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@erlend-aasland erlend-aasland enabled auto-merge (squash) April 30, 2024 19:31
@erlend-aasland
Copy link
Contributor Author

Thanks for the review, Serhiy!

@erlend-aasland erlend-aasland merged commit b568c2c into python:main Apr 30, 2024
36 checks passed
@erlend-aasland erlend-aasland deleted the sqlite/cx-sig branch April 30, 2024 19:58
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@erlend-aasland @SonicField
pythongh-118406: Add signature for sqlite3.Connection objects (python…
692c94f 
…#118428)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement inspect.signature() for sqlite3 connection object
3 participants
@erlend-aasland @bedevere-bot @serhiy-storchaka