Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-118374: Add ctx argument to ast.Name calls #118375

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Apr 29, 2024

Before this PR:

./python.exe -m test -q test_ast
Using random seed: 2061872940
0:00:00 load avg: 4.08 Run 1 test sequentially
/Users/admin/Projects/cpython/Lib/test/test_ast.py:1356: DeprecationWarning: Name.__init__ missing 1 required positional argument: 'ctx'. This will become an error in Python 3.15.
  [ast.Name('dataclass')],

== Tests result: SUCCESS ==

Total duration: 3.3 sec
Total tests: run=168 skipped=1
Total test files: run=1/1
Result: SUCCESS

After this PR:

./python.exe -m test -q test_ast                     
Using random seed: 491163465
0:00:00 load avg: 6.26 Run 1 test sequentially

== Tests result: SUCCESS ==

Total duration: 955 ms
Total tests: run=168 skipped=1
Total test files: run=1/1
Result: SUCCESS

@Eclips4 Eclips4 requested a review from sobolevn April 29, 2024 05:17
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Apr 29, 2024
@JelleZijlstra
Copy link
Member

Thank you for noticing and fixing this issue!

@JelleZijlstra JelleZijlstra merged commit aa8f6d2 into python:main Apr 29, 2024
36 checks passed
@Eclips4 Eclips4 deleted the issue-118374 branch April 29, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants