Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-116749: Disable GIL by default in free-threaded build #118295

Merged
merged 2 commits into from
Apr 26, 2024
Merged

gh-116749: Disable GIL by default in free-threaded build #118295

merged 2 commits into from
Apr 26, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Apr 25, 2024 •
edited by bedevere-app bot
Loading

Switch GIL to disabled by default in free-threaded build so that the free-threaded CIs catch thread-safety issues.

@colesbury
pythongh-116749: Disable GIL by default in free-threaded build
9fc88f4 
Switch GIL to disabled by default in free-threaded build so that the
free-threaded CIs catch thread-safety issues.
@colesbury
Copy link
Contributor Author

!buildbot nogil

@bedevere-app bedevere-app bot mentioned this pull request Apr 25, 2024
Closed
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 9fc88f4 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • ARM64 MacOS M1 NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Ubuntu NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • x86-64 MacOS Intel NoGIL PR

@colesbury colesbury marked this pull request as ready for review April 26, 2024 15:04
SonicField
SonicField approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@SonicField SonicField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

swtaarrs
swtaarrs reviewed Apr 26, 2024
View reviewed changes
Python/initconfig.c Outdated Show resolved Hide resolved
DinoV
DinoV approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@DinoV DinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!!

swtaarrs
swtaarrs approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@swtaarrs swtaarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting 😃

@colesbury colesbury merged commit 5a90de0 into python:main Apr 26, 2024
36 checks passed
@colesbury colesbury deleted the gh-116749-disable-gil branch April 26, 2024 18:22
@colesbury colesbury mentioned this pull request Apr 26, 2024
Closed
@corona10
Copy link
Member

Historical moment!

@cychen2021
Copy link

Cool!

@swtaarrs swtaarrs mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swtaarrs swtaarrs swtaarrs approved these changes

@DinoV DinoV DinoV approved these changes

@SonicField SonicField SonicField approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@colesbury @bedevere-bot @corona10 @cychen2021 @swtaarrs @DinoV @SonicField