Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35877: Add test for while loop named expression without parentheses #11726

Merged
merged 1 commit into from
Feb 1, 2019
Merged

bpo-35877: Add test for while loop named expression without parentheses #11726

merged 1 commit into from
Feb 1, 2019

Conversation

emilyemorehouse
Copy link
Member

@emilyemorehouse emilyemorehouse commented Feb 1, 2019 •
edited by bedevere-bot
Loading

This adds an additional test (and fixes a comment typo) in test_named_expressions based on #11724

https://bugs.python.org/issue35877

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting merge labels Feb 1, 2019
tirkarthi
tirkarthi approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@emilyemorehouse emilyemorehouse merged commit ac19081 into python:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emilyemorehouse @tirkarthi @the-knights-who-say-ni @bedevere-bot