Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35780: Fix errors in lru_cache() C code #11715

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Jan 31, 2019

The previous PR fixed the location of the misses update in the bounded_lru_cache_wrapper(). This PR fixes the other two wrappers as well. Misses now has a consistent definition of being the number of times the argument pattern was not found in the cache.

https://bugs.python.org/issue35780

@rhettinger rhettinger added type-bug An unexpected behavior, bug, or error skip news needs backport to 3.7 labels Jan 31, 2019
@rhettinger rhettinger closed this Jan 31, 2019
@rhettinger rhettinger reopened this Jan 31, 2019
@rhettinger rhettinger merged commit ffdf1c3 into python:master Jan 31, 2019
@miss-islington
Copy link
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2019
…call (pythonGH-11715)

(cherry picked from commit ffdf1c3)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@bedevere-bot
Copy link

GH-11716 is a backport of this pull request to the 3.7 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants