Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35854: Fix EnvBuilder and ignore --symlinks in venv on Windows #11700

Merged
merged 7 commits into from
Jan 30, 2019
Merged

bpo-35854: Fix EnvBuilder and ignore --symlinks in venv on Windows #11700

merged 7 commits into from
Jan 30, 2019

Conversation

zooba
Copy link
Member

@zooba zooba commented Jan 29, 2019 •
edited by bedevere-bot
Loading

@zooba zooba closed this Jan 30, 2019
@zooba zooba reopened this Jan 30, 2019
@zooba
Copy link
Member Author

zooba commented Jan 30, 2019

New Pipelines build running at https://dev.azure.com/Python/cpython/_build/results?buildId=37304&view=logs - no idea why it's failing to start this evening, but it may be left over from an authentication outage we had earlier today.

@zooba zooba closed this Jan 30, 2019
@zooba zooba reopened this Jan 30, 2019
@zooba zooba merged commit a1f9a33 into python:master Jan 30, 2019
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 30, 2019
@zooba @miss-islington
bpo-35854: Fix EnvBuilder and --symlinks in venv on Windows (pythonGH…
34a2938 
…-11700)

(cherry picked from commit a1f9a33)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@bedevere-bot
Copy link

GH-11707 is a backport of this pull request to the 3.7 branch.

@zooba zooba deleted the bpo-35854 branch January 30, 2019 21:49
miss-islington added a commit that referenced this pull request Jan 30, 2019
@miss-islington @zooba
bpo-35854: Fix EnvBuilder and --symlinks in venv on Windows (GH-11700)
03082a8 
(cherry picked from commit a1f9a33)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
OS-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zooba @miss-islington @bedevere-bot @the-knights-who-say-ni