Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35835: Add reference to Python 3.7 new breakpoint() function in pdb documentation. #11691

Merged
merged 3 commits into from
Jan 30, 2019
Merged

bpo-35835: Add reference to Python 3.7 new breakpoint() function in pdb documentation. #11691

merged 3 commits into from
Jan 30, 2019

Conversation

jcrmatos
Copy link
Contributor

@jcrmatos jcrmatos commented Jan 28, 2019 •
edited by Mariatta
Loading

No description provided.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 28, 2019
warsaw
warsaw reviewed Jan 28, 2019
View reviewed changes
Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"with defaults" also means that the PYTHONBREAKPOINT environment variable isn't set. Should the docs here mention that or is it enough to just link to breakpoint() documentation?

@jcrmatos
Copy link
Contributor Author

I think it is enough to just link to breakpoint() documentation. Can you add the "skip news" label?

Mariatta
Mariatta reviewed Jan 28, 2019
View reviewed changes
Doc/library/pdb.rst Outdated Show resolved Hide resolved
Mariatta and others added 2 commits January 28, 2019 19:20
@Mariatta @jcrmatos
Comply with max line length.
eff06f5 
Co-Authored-By: jcrmatos <jcrmatos@gmail.com>
@jcrmatos
Remove trailing white space.
18082c1
@Mariatta
Copy link
Member

Thanks @jcrmatos. This LGTM.
@warsaw do you have additional concerns? If not, I'll add the automerge label. Thanks.

eamanu
eamanu approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcrmatos
Copy link
Contributor Author

Do I have to do anything else? Or have to wait until someone with the required write access to merge?

@Mariatta
Copy link
Member

I was waiting for the CLA.

@Mariatta Mariatta changed the title bpo-35835: Add reference to Python 3.7 new breakpoint() function. bpo-35835: Add reference to Python 3.7 new breakpoint() function in pdb documentation. Jan 30, 2019
@miss-islington miss-islington merged commit cf991e6 into python:master Jan 30, 2019
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

@miss-islington
Copy link
Contributor

Thanks @jcrmatos for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 30, 2019
@jcrmatos @miss-islington
bpo-35835: Add reference to Python 3.7 new breakpoint() function in p…
3aed18b 
…db documentation. (pythonGH-11691)

(cherry picked from commit cf991e6)

Co-authored-by: João Matos <jcrmatos@gmail.com>
@bedevere-bot
Copy link

GH-11702 is a backport of this pull request to the 3.7 branch.

@Mariatta
Copy link
Member

Thanks @jcrmatos and congrats on your first contribution to CPython 🌮

@jcrmatos
Copy link
Contributor Author

Thank you for the help.

@jcrmatos jcrmatos deleted the fix-issue-35835 branch January 30, 2019 17:27
miss-islington added a commit that referenced this pull request Jan 30, 2019
@miss-islington @jcrmatos
bpo-35835: Add reference to Python 3.7 new breakpoint() function in p…
7516f26 
…db documentation. (GH-11691)

(cherry picked from commit cf991e6)

Co-authored-by: João Matos <jcrmatos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warsaw warsaw warsaw left review comments

@Mariatta Mariatta Mariatta approved these changes

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jcrmatos @the-knights-who-say-ni @Mariatta @miss-islington @bedevere-bot @warsaw @eamanu