-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-116621: Specialize list.extend for dict items #116888
Conversation
Objects/listobject.c
Outdated
return -1; | ||
} | ||
|
||
// TODO: Don't start a garbage collection cycle when creating tuples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't start GC when allocating objects (since 3.12)
Objects/listobject.c
Outdated
Py_SET_SIZE(self, m + i); | ||
return -1; | ||
} | ||
FT_ATOMIC_STORE_PTR_RELAXED(*dest, item); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want RELEASE
here.
We probably want to do the same thing for the other list_extend
functions.
list(set)
should be atomic in the free-threaded build #116621