Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-111926: Simplify proxy creation logic #116844

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

mpage
Copy link
Contributor

@mpage mpage commented Mar 14, 2024

Since 3.12 allocating a GC-able object cannot trigger GC. This allows us to simplify the logic for creating the canonical callback-less proxy object.

Since 3.12 allocating a GC-able object cannot trigger GC. This allows
us to simplify the logic for creating the canonical callback-less
proxy object.
@mpage
Copy link
Contributor Author

mpage commented Mar 15, 2024

The CIFuzz (memory) failure is unrelated to this PR. It's failing in the same way on other PRs and likely main.

@mpage mpage requested a review from colesbury March 15, 2024 01:35
@mpage mpage marked this pull request as ready for review March 15, 2024 01:36
@colesbury colesbury merged commit ce2c996 into python:main Mar 15, 2024
35 of 36 checks passed
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
Since 3.12, allocating a GC-able object cannot trigger GC. This allows
us to simplify the logic for creating the canonical callback-less
proxy object.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
Since 3.12, allocating a GC-able object cannot trigger GC. This allows
us to simplify the logic for creating the canonical callback-less
proxy object.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Since 3.12, allocating a GC-able object cannot trigger GC. This allows
us to simplify the logic for creating the canonical callback-less
proxy object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants