Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-116417: Avoid PyFloat_AS_DOUBLE() in AC limited C API #116568

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 10, 2024

Argument Clinic no longer calls PyFloat_AS_DOUBLE() when the usage of the limited C API is requested.

Argument Clinic no longer calls PyFloat_AS_DOUBLE() when the usage of
the limited C API is requested.
@vstinner
Copy link
Member Author

cc @erlend-aasland

@vstinner vstinner merged commit 729bfb3 into python:main Mar 10, 2024
41 checks passed
@vstinner vstinner deleted the ac_float branch March 10, 2024 19:42
@erlend-aasland
Copy link
Contributor

Thanks!

@vstinner
Copy link
Member Author

I'm working on a large refactoring of C API tests and I need to merge multiple small changes in a row. Thanks for the follow-up, I'm not used to AC tests. First I even wanted to avoid tests, but then I recall limited C API tests for AC. At least, check that generated C code compiles properly.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
…n#116568)

Argument Clinic no longer calls PyFloat_AS_DOUBLE() when the usage of
the limited C API is requested.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…n#116568)

Argument Clinic no longer calls PyFloat_AS_DOUBLE() when the usage of
the limited C API is requested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants