Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-114911: Add CPUStopwatch test helper #114912

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Conversation

encukou
Copy link
Member

@encukou encukou commented Feb 2, 2024

A few of our tests measure the time of CPU-bound operation, mainly to avoid quadratic or worse behaviour.
Add a helper to ignore GC and time spent in other processes.

A few of our tests measure the time of CPU-bound operation, mainly
to avoid quadratic or worse behaviour.
Add a helper to ignore GC and time spent in other processes.
@encukou
Copy link
Member Author

encukou commented Feb 12, 2024

@vstinner, do you like this test helper?

@vstinner
Copy link
Member

@vstinner, do you like this test helper?

I'm not sure that it's going to fix the root issue: #114911 (comment)

@encukou
Copy link
Member Author

encukou commented Feb 12, 2024

It's not; I want to add it to help diagnosing similar issues (by filtering out unrelated causes).

@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 16, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit bed30c3 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 16, 2024
@encukou
Copy link
Member Author

encukou commented Feb 20, 2024

The WASI buildbot fails because... on WASI time runs a million times faster: #115714

@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 0d29c04 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2024
@vstinner
Copy link
Member

I'm not sure that it's going to fix the root issue: #114911 (comment)

Please, ignore my comment. I didn't find time to fully review this change and dig into this issue ;-)

@encukou
Copy link
Member Author

encukou commented Feb 23, 2024

The WASI clock has been sacked; tests are green.

@vstinner Thank you for digging in! Any objections to merging this?
(I'm not asking for a full formal review, unless you want to do one -- but I don't want to merge if you're still looking at this.)

@encukou encukou merged commit 7acf1fb into python:main Feb 28, 2024
113 of 114 checks passed
@encukou encukou deleted the int_test_timeout branch February 28, 2024 11:53
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
A few of our tests measure the time of CPU-bound operation, mainly
to avoid quadratic or worse behaviour.
Add a helper to ignore GC and time spent in other processes.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
A few of our tests measure the time of CPU-bound operation, mainly
to avoid quadratic or worse behaviour.
Add a helper to ignore GC and time spent in other processes.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
A few of our tests measure the time of CPU-bound operation, mainly
to avoid quadratic or worse behaviour.
Add a helper to ignore GC and time spent in other processes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants