gh-60346: Improve handling single-dash options in ArgumentParser.parse_known_args() #114180
+57
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serhiy-storchaka
commented
Jan 17, 2024
•
serhiy-storchaka
commented
- Issue: ArgumentParser inconsistent with parse_known_args #60346
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 19, 2024
…r.parse_known_args() (pythonGH-114180) (cherry picked from commit e47ecbd) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-115674 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 19, 2024
…r.parse_known_args() (pythonGH-114180) (cherry picked from commit e47ecbd) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-115675 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Feb 19, 2024
serhiy-storchaka
added a commit
that referenced
this pull request
Feb 19, 2024
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
…r.parse_known_args() (pythonGH-114180)
clalancette
added a commit
to colcon/colcon-core
that referenced
this pull request
Apr 9, 2024
The comment in the code has more details, but as of python/cpython#114180 we need to check for both a 3-tuple and a 4-tuple. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
added a commit
to colcon/colcon-core
that referenced
this pull request
Apr 9, 2024
The comment in the code has more details, but as of python/cpython#114180 we need to check for both a 3-tuple and a 4-tuple. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
added a commit
to colcon/colcon-core
that referenced
this pull request
Apr 9, 2024
The comment in the code has more details, but as of python/cpython#114180 we need to check for both a 3-tuple and a 4-tuple. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
added a commit
to colcon/colcon-core
that referenced
this pull request
Apr 9, 2024
The comment in the code has more details, but as of python/cpython#114180 we need to check for both a 3-tuple and a 4-tuple. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
cottsay
pushed a commit
to colcon/colcon-core
that referenced
this pull request
Apr 9, 2024
The comment in the code has more details, but as of python/cpython#114180 we need to check for both a 3-tuple and a 4-tuple. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…r.parse_known_args() (pythonGH-114180)
antecrescent
added a commit
to antecrescent/pkgcheck
that referenced
this pull request
May 8, 2024
ArgumentParser added a separator to its option tuple with >=python-3.11.9, which snakeoil-0.10.7 does not handle correctly. python/cpython#114180 Signed-off-by: Lucio Sauer <watermanpaint@posteo.net>
gentoo-bot
pushed a commit
to pkgcore/pkgcheck
that referenced
this pull request
May 8, 2024
ArgumentParser added a separator to its option tuple with >=python-3.11.9, which snakeoil-0.10.7 does not handle correctly. python/cpython#114180 Signed-off-by: Lucio Sauer <watermanpaint@posteo.net> Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.