Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-111807: Lower the parser stack depth under WASI debug builds #112225

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Nov 18, 2023

@brettcannon
Copy link
Member Author

Somewhat off-topic, but if we require a bootstrapping Python interpreter these days, is there any reason why pegen has to be regenerated manually and checked in instead of being generated by make in the checkout itself?

@pablogsal
Copy link
Member

is there any reason why pegen has to be regenerated manually and checked in instead of being generated by make in the checkout itself?

The original reasons were that we checkout the rest of regenerated files and having them in the tree helps reviews because even if is regenerated is very easy to review what's going on if the code is diffed. Additionally, it helps when developing because we can go back to previous versions if we messes something without having to change an in-flight edited grammar. I have also checked the file plenty of times in the GH interface to look for certain behaviours. I suppose we could live without any of these if someone feels strongly about starting to remove auto-generated files.

@lysnikolaou
Copy link
Contributor

I have also checked the file plenty of times in the GH interface to look for certain behaviours.

Same here. This has been useful a handful of times.

@pablogsal pablogsal merged commit 56e59a4 into python:main Nov 20, 2023
37 checks passed
@brettcannon brettcannon deleted the parser-MAXSTACK-wasi-debug branch November 21, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants