Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106581: Honor 'always_exits' in write_components() #109338

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Sep 12, 2023

I must have overlooked this when refactoring the code generator. The Tier 1 interpreter contained a few silly things like

            goto resume_frame;
            STACK_SHRINK(1);

(and other variations, some where the unconditional goto was hidden in a macro).

I'll just merge this once tests pass.

@gvanrossum gvanrossum enabled auto-merge (squash) September 12, 2023 17:34
@gvanrossum gvanrossum merged commit b86ce91 into python:main Sep 12, 2023
25 of 26 checks passed
@gvanrossum gvanrossum deleted the always-exits-fix branch September 13, 2023 02:04
vstinner pushed a commit to vstinner/cpython that referenced this pull request Sep 13, 2023
…09338)

I must have overlooked this when refactoring the code generator.
The Tier 1 interpreter contained a few silly things like
```
            goto resume_frame;
            STACK_SHRINK(1);
```
(and other variations, some where the unconditional `goto` was hidden in a macro).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant