gh-107603: Argument Clinic: Only include pycore_gc.h if needed #108726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
requested review from
erlend-aasland,
AlexWaygood,
corona10,
ethanfurman,
gvanrossum,
Fidget-Spinner,
JelleZijlstra,
rhettinger,
a team,
berkerpeksag,
pganssle,
abalkin,
brettcannon,
ericsnowcurrently,
ncoghlan,
warsaw,
tiran,
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
Argument Clinic now only includes pycore_gc.h if PyGC_Head is needed, and only includes pycore_runtime.h if _Py_ID() is needed. * Add 'condition' optional argument to Clinic.add_include(). * deprecate_keyword_use() includes pycore_runtime.h when using the _PyID() function. * Fix rendering of includes: comments start at the column 35. * Mark PC/clinic/_wmimodule.cpp.h and "Objects/stringlib/clinic/*.h.h" header files as generated in .gitattributes. Effects: * 42 header files generated by AC no longer include the internal C API, instead of 4 header files before. For example, Modules/clinic/_abc.c.h no longer includes the internal C API. * Fix _testclinic_depr.c.h: it now always includes pycore_runtime.h to get _Py_ID().
vstinner
force-pushed
the
clinic_includes3
branch
from
f75136c
to
e89f507
Compare
AlexWaygood
reviewed
Aug 31, 2023
AlexWaygood
reviewed
Aug 31, 2023
AlexWaygood
reviewed
Aug 31, 2023
|
@AlexWaygood: Please review my updated PR. I addressed your latest review. |
rhettinger
removed request for
a team,
rhettinger,
erlend-aasland,
Fidget-Spinner and
kumaraditya303
erlend-aasland
changed the title
erlend-aasland
approved these changes
Aug 31, 2023
In general, |
AlexWaygood
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
LGTM
I also don't like to pass around
cliniclike that
Yeah, agreed that this maybe isn't the best pattern, but we can always refactor at a later date — I think this is fine for now.
Thanks for the updates @vstinner!
|
Merged, thanks for reviews @AlexWaygood and @erlend-aasland! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argument Clinic now only includes pycore_gc.h if PyGC_Head is needed, and only includes pycore_runtime.h if _Py_ID() is needed.
Effects: