Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-108488: Initialize JUMP_BACKWARD cache to 0, not 17 #108591

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Aug 28, 2023

@gvanrossum gvanrossum marked this pull request as ready for review August 28, 2023 22:22
@gvanrossum
Copy link
Member Author

gvanrossum commented Aug 28, 2023

(Calling out @markshannon or @brandtbucher because one of you might care about how fast the inner loop of _PyCode_Quicken() is -- this adds a branch. Though note that once we are tracking how common branches are taken, we'll get more exceptions in this loop. And hopefully the hardware CPU's branch predictor will predict this branch well.)

@gvanrossum gvanrossum enabled auto-merge (squash) August 29, 2023 17:44
@gvanrossum gvanrossum merged commit 59e4693 into python:main Aug 29, 2023
21 of 22 checks passed
@gvanrossum gvanrossum deleted the init-jump-back-cache branch August 29, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Counter for JUMP_BACKWARD is initialized to 17 instead of 0
2 participants