-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-107406: Add better struct.Struct
repr
#107407
Conversation
Misc/NEWS.d/next/Library/2023-07-29-02-01-24.gh-issue-107406.ze6sQP.rst
Outdated
Show resolved
Hide resolved
…e6sQP.rst Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks right to me and this is definitely an improvement.
Do we need to be concerned about compatibility? I don't think we guarantee backward compatibility for the repr()
.
Should we document the new A |
I don't think we need to document the method itself. However, a note in the struct docs with versionchanged 3.13 saying that the repr() is now informative would be good. |
when will it be merged? |
There's a new commit after the PR has been approved. @kumaraditya303, @JelleZijlstra: please review the changes made to this pull request. |
|
fixes #107406
struct.Struct
repr #107406