Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-106909: Use role :const: for referencing module constants #106910

Merged
merged 1 commit into from
Jul 21, 2023
Merged

gh-106909: Use role :const: for referencing module constants #106910

merged 1 commit into from
Jul 21, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 20, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir labels Jul 20, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 20, 2023
Closed
@serhiy-storchaka serhiy-storchaka merged commit 4b99486 into python:main Jul 21, 2023
23 checks passed
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 4b9948617f91175783609769aa6160e5b49b9ccc 3.12

@serhiy-storchaka serhiy-storchaka deleted the docs-const-roles branch July 21, 2023 09:40
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4b9948617f91175783609769aa6160e5b49b9ccc 3.11

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 21, 2023
@serhiy-storchaka
[3.12] pythongh-106909: Use role :const: for referencing module const…
f8d9a26 
…ants (pythonGH-106910).

(cherry picked from commit 4b99486)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-106956 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 21, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jul 21, 2023
@serhiy-storchaka
[3.11] pythongh-106909: Use role :const: for referencing module const…
71234b0 
…ants (pythonGH-106910).

(cherry picked from commit 4b99486)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-106957 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 21, 2023
serhiy-storchaka added a commit that referenced this pull request Jul 21, 2023
@serhiy-storchaka
[3.12] gh-106909: Use role :const: for referencing module constants (G…
84e5217 
…H-106910) (GH-106956)

(cherry picked from commit 4b99486)
serhiy-storchaka added a commit that referenced this pull request Jul 21, 2023
@serhiy-storchaka
[3.11] gh-106909: Use role :const: for referencing module constants (G…
b338ac7 
…H-106910) (GH-106957)

(cherry picked from commit 4b99486)
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @erlend-aasland