gh-104050: Argument Clinic: Annotate output_templates()

[erlend-aasland]

• Issue: Add type annotations to clinic.py #104050

[AlexWaygood]

The mypy error might indicate we have the wrong annotation for Parameter.converter

Edit: no, don't think that's the issue actually

[erlend-aasland]

Thanks for 6891e14! The last error puzzles me, though, and I have no bandwidth for this today; if you find a solution, feel free to land this :)

[AlexWaygood]

The last error puzzles me, though, and I have no bandwidth for this today; if you find a solution, feel free to land this

Yeah, I can't immediately tell what the issue is here. I'm investigating :)

Mypy doesn't have a great understanding of multiple inheritance, so this may be a false positive. But not sure.

[erlend-aasland]

Aaah, perhaps it is line 801 and 802:

assert isinstance(parameters[0].converter, self_converter)
del parameters[0]

My guess: mypy uses only the information provided in line 801, but is not smart enough to see that line 802 invalidates that assert, so it continues to think parameters[0] is asserted as a self_converter instance.

[AlexWaygood]

Aaah, perhaps it is line 801 and 802:

assert isinstance(parameters[0].converter, self_converter)
del parameters[0]

My guess: mypy uses only the information provided in line 801, but is not smart enough to see that line 802 invalidates that assert, so it continues to think parameters[0] is asserted as a self_converter instance.

Bingo! I'll push a fix.

[AlexWaygood]

Does f9cb537 look good to you?

[erlend-aasland]

Does f9cb537 look good to you?

Neat!

[AlexWaygood]

Thanks!