bpo-25438: document what codec PyMemberDef T_STRING decodes the char * as #10580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysnikolaou
requested changes
Nov 17, 2018
adds missing :c:macro: annotation, splits the run on sentence, and limits line length.
unrelated to the issue, and "multiple assignment" not plural is considered to be a single thing in the contexts I've heard it used.
gpshead
approved these changes
Nov 17, 2018
|
@Windsooon: Status check is done, and it's a failure ❌ . |
|
@Windsooon: Status check is done, and it's a success ✅ . |
|
Thanks @Windsooon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 17, 2018
…* as (pythonGH-10580) Source of T_STRING: https://github.com/python/cpython/blob/e42b705188271da108de42b55d9344642170aa2b/Python/structmember.cGH-L51 Source of PyUnicode_FromString https://github.com/python/cpython/blob/master/Include/unicodeobject.hGH-L702 https://bugs.python.org/issue25438 (cherry picked from commit 689d555) Co-authored-by: Windson yang <wiwindson@outlook.com>
|
GH-10586 is a backport of this pull request to the 3.7 branch. |
|
GH-10587 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 17, 2018
…* as (pythonGH-10580) Source of T_STRING: https://github.com/python/cpython/blob/e42b705188271da108de42b55d9344642170aa2b/Python/structmember.cGH-L51 Source of PyUnicode_FromString https://github.com/python/cpython/blob/master/Include/unicodeobject.hGH-L702 https://bugs.python.org/issue25438 (cherry picked from commit 689d555) Co-authored-by: Windson yang <wiwindson@outlook.com>
miss-islington
added a commit
that referenced
this pull request
Nov 17, 2018
… char * as (GH-10580) (GH-10586) Source of T_STRING: https://github.com/python/cpython/blob/e42b705188271da108de42b55d9344642170aa2b/Python/structmember.cGH-L51 Source of PyUnicode_FromString https://github.com/python/cpython/blob/master/Include/unicodeobject.hGH-L702 https://bugs.python.org/issue25438 (cherry picked from commit 689d555) Co-authored-by: Windson yang <wiwindson@outlook.com> https://bugs.python.org/issue25438
miss-islington
added a commit
that referenced
this pull request
Nov 17, 2018
… char * as (GH-10580) (GH-10587) Source of T_STRING: https://github.com/python/cpython/blob/e42b705188271da108de42b55d9344642170aa2b/Python/structmember.cGH-L51 Source of PyUnicode_FromString https://github.com/python/cpython/blob/master/Include/unicodeobject.hGH-L702 https://bugs.python.org/issue25438 (cherry picked from commit 689d555) Co-authored-by: Windson yang <wiwindson@outlook.com> https://bugs.python.org/issue25438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source of T_STRING:
cpython/Python/structmember.c
Line 51 in e42b705
Source of PyUnicode_FromString
https://github.com/python/cpython/blob/master/Include/unicodeobject.h#L702
https://bugs.python.org/issue25438