Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105286: Further improvements to typing.py docstrings #105363

Merged
merged 1 commit into from
Jun 7, 2023
Merged

gh-105286: Further improvements to typing.py docstrings #105363

merged 1 commit into from
Jun 7, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jun 6, 2023 •
edited by bedevere-bot
Loading

A small followup PR to #105287

@bedevere-bot bedevere-bot mentioned this pull request Jun 6, 2023
Closed
@JelleZijlstra JelleZijlstra merged commit 9a89f1b into python:main Jun 7, 2023
@miss-islington
Copy link
Contributor

Thanks @AlexWaygood for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @AlexWaygood and @JelleZijlstra, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9a89f1bf1e7bb819fe7240be779c99a84f47ea46 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 7, 2023
@AlexWaygood @miss-islington
pythongh-105286: Further improvements to typing.py docstrings (pyth…
cedc709 
…onGH-105363)

(cherry picked from commit 9a89f1b)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot
Copy link

GH-105416 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 7, 2023
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Jun 7, 2023
@AlexWaygood @JelleZijlstra
[3.11] pythongh-105286: Further improvements to typing.py docstrings (
07a6713 
pythonGH-105363).

(cherry picked from commit 9a89f1b)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot
Copy link

GH-105417 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 7, 2023
JelleZijlstra pushed a commit that referenced this pull request Jun 7, 2023
@miss-islington @AlexWaygood
[3.12] gh-105286: Further improvements to typing.py docstrings (GH-…
84133c5 
…105363) (#105416)

gh-105286: Further improvements to `typing.py` docstrings (GH-105363)
(cherry picked from commit 9a89f1b)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood AlexWaygood deleted the more-docstring-improvements branch June 7, 2023 06:39
AlexWaygood added a commit that referenced this pull request Jun 7, 2023
@JelleZijlstra @AlexWaygood
[3.11] gh-105286: Further improvements to typing.py docstrings (GH-…
3a195f3 
…105363) (#105417)

[3.11] gh-105286: Further improvements to `typing.py` docstrings (GH-105363).
(cherry picked from commit 9a89f1b)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels
skip news topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexWaygood @miss-islington @bedevere-bot @JelleZijlstra