gh-104879: Fix TypeAliasType.__module__ in exec() #104881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JelleZijlstra
commented
May 24, 2023
•
JelleZijlstra
commented
- Issue: TypeAliasType.__module__ can segfault #104879
JelleZijlstra
requested review from
gvanrossum,
Fidget-Spinner,
AlexWaygood and
markshannon
as code owners
JelleZijlstra
commented
May 24, 2023
| @@ -373,6 +373,20 @@ def test_basic_plain(self): | |||
| self.assertIs(T.__covariant__, False) | |||
| self.assertIs(T.__contravariant__, False) | |||
| self.assertIs(T.__infer_variance__, False) | |||
| self.assertEqual(T.__module__, __name__) | |||
|
|
|||
| def test_basic_with_exec(self): | |||
There was a problem hiding this comment.
These tests already passed, but adding them here for completeness
JelleZijlstra
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit a6e5d5e 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
sunmy2019
approved these changes
May 24, 2023
Eclips4
approved these changes
May 24, 2023
|
Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 24, 2023
) (cherry picked from commit fe77a99) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
GH-104890 is a backport of this pull request to the 3.12 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.